Choice non string lists #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
reviewed
Feb 28, 2025
| @@ -116,6 +116,8 @@ def build(c: Union[str, "Choice", Dict[str, Any]]) -> "Choice": | |||
| return c | |||
| elif isinstance(c, str): | |||
| return Choice(c, c) | |||
| elif isinstance(c, (int, bool, float)): # Ajout pour les types primitifs | |||
There was a problem hiding this comment.
looks good, do you mind changing the functions comment as well, stating that these types are allowed as well?
please remove frensh comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Closes #413
The issue addressed by this PR is the inability to handle non-string items in choice prompts. Previously, using lists or arrays containing integers, floats, booleans, or other non-string objects in the choices parameter caused runtime errors. This limitation impacted use cases requiring dynamic, type-diverse choices.
How did you solve it?
The solution involves enhancing the Choice.build method and related components in common.py to support non-string objects. Specifically:
The Choice.build method now converts non-string items into displayable strings for rendering while preserving their original type as the choice value.
Updated logic in InquirerControl to handle the mixed types seamlessly, ensuring compatibility with existing features such as shortcuts and separators.
Comprehensive unit tests were added to validate the behavior with non-string items, covering integers, floats, booleans, and mixed-type lists.
Checklist