use constants

tlm-solutions · Jun 16, 2024 · d4daa4e · d4daa4e
1 parent ddbd97a
commit d4daa4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/include/l2/logical_link_control.hpp b/include/l2/logical_link_control.hpp
@@ -68,6 +68,9 @@ class LogicalLinkControl {
     friend auto operator<<(std::ostream& stream, const LogicalLinkControl& llc) -> std::ostream&;
 
   private:
+    static const auto kSupplementaryLlcPdu = 13;
+    static const auto kLayer2SignallingPdu = 14;
+
     std::array<std::string, 16> llc_pdu_description_;
     std::array<std::string, 4> supplementary_llc_pdu_description_;
     std::array<std::string, 16> layer_2_signalling_pdu_description_;

diff --git a/src/l2/logical_link_control.cpp b/src/l2/logical_link_control.cpp
@@ -36,7 +36,7 @@ void LogicalLinkControl::process(const Address address, BitVector& vec) {
     const auto& pdu_name = llc_pdu_description_.at(pdu_type);
 
     // Skip incrementing the metrics for Supplementary LLC PDU and Layer 2 signalling PDU
-    if (metrics_ && (pdu_type != 13) && (pdu_type != 14)) {
+    if (metrics_ && (pdu_type != kSupplementaryLlcPdu) && (pdu_type != kLayer2SignallingPdu)) {
         metrics_->increment(pdu_name);
     }