Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-builder: add page #13449

Merged
merged 9 commits into from
Aug 28, 2024
Merged

kde-builder: add page #13449

merged 9 commits into from
Aug 28, 2024

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Aug 16, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Aug 16, 2024
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/kde-builder.md seems to be a copy of pages/linux/kdesrc-build.md (53% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

pages/linux/kde-builder.md Outdated Show resolved Hide resolved
@kbdharun kbdharun self-requested a review August 16, 2024 15:45
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, for now, I would like to only add this suggestion, based on discussion #13441, I will make a few suggestions for the short options soon.

pages/linux/kde-builder.md Outdated Show resolved Hide resolved
@spageektti spageektti requested a review from kbdharun August 28, 2024 14:37
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay (had a lot of work the past few days). After adding this the PR should be GTG.

pages/linux/kde-builder.md Outdated Show resolved Hide resolved
pages/linux/kde-builder.md Outdated Show resolved Hide resolved
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@spageektti spageektti merged commit 5b64e2a into tldr-pages:main Aug 28, 2024
4 checks passed
@Managor Managor deleted the kde-builder branch September 7, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants