-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove support for pydantic v1 #275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 86.95% 86.52% -0.44%
==========================================
Files 25 25
Lines 1273 1247 -26
==========================================
- Hits 1107 1079 -28
- Misses 166 168 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #275 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's time to let v1 support go. It's so cathartic to rip out this kind of code.
The main thing that people may now see is that using |
closes #274
won't merge this one without approval