Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove support for pydantic v1 #275

Merged
merged 6 commits into from
Jan 3, 2025
Merged

refactor: remove support for pydantic v1 #275

merged 6 commits into from
Jan 3, 2025

Conversation

tlambert03
Copy link
Owner

closes #274

won't merge this one without approval

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (ae694b6) to head (aba74e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ome_types/_mixins/_kinded.py 90.00% 1 Missing ⚠️
src/ome_types/widget.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   86.95%   86.52%   -0.44%     
==========================================
  Files          25       25              
  Lines        1273     1247      -26     
==========================================
- Hits         1107     1079      -28     
- Misses        166      168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #275 will not alter performance

Comparing drop-pydantic1 (aba74e3) with main (ae694b6)

Summary

✅ 9 untouched benchmarks

Copy link
Collaborator

@jmuhlich jmuhlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's time to let v1 support go. It's so cathartic to rip out this kind of code.

@tlambert03
Copy link
Owner Author

The main thing that people may now see is that using .dict() and other v1 methods will now reveal the deprecation warnings that pydantic-compat was hiding. So you may need to change some code after this

@tlambert03 tlambert03 enabled auto-merge (squash) January 3, 2025 20:02
@tlambert03 tlambert03 merged commit e294e4c into main Jan 3, 2025
33 of 34 checks passed
@tlambert03 tlambert03 deleted the drop-pydantic1 branch January 3, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: drop support for pydantic v1
2 participants