Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop python 3.8 #268

Merged
merged 2 commits into from
Nov 21, 2024
Merged

build: drop python 3.8 #268

merged 2 commits into from
Nov 21, 2024

Conversation

tlambert03
Copy link
Owner

will cover adding python 3.13 in #260

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (31c7830) to head (6ede683).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   86.77%   86.84%   +0.07%     
==========================================
  Files          25       25              
  Lines        1255     1262       +7     
==========================================
+ Hits         1089     1096       +7     
  Misses        166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #268 will improve performances by 15.23%

Comparing drop38 (6ede683) with main (31c7830)

Summary

⚡ 2 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark main drop38 Change
test_time_from_dict_to_ome[med] 28.8 ms 25.1 ms +14.55%
test_time_from_dict_to_ome[small] 2.5 ms 2.2 ms +15.23%

@tlambert03 tlambert03 merged commit e4bda9e into main Nov 21, 2024
35 checks passed
@tlambert03 tlambert03 deleted the drop38 branch November 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant