Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia 1.0 #10

Merged
merged 14 commits into from
Aug 21, 2018
Merged

Support Julia 1.0 #10

merged 14 commits into from
Aug 21, 2018

Conversation

tkf
Copy link
Owner

@tkf tkf commented Aug 20, 2018

(Edit: actually I don't need PyJulia for this)

unless I do Pkg.add explicitly.
@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #10 into master will decrease coverage by 3.57%.
The diff coverage is 72.22%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10      +/-   ##
=======================================
- Coverage   78.57%   75%   -3.58%     
=======================================
  Files           4     4              
  Lines          84    92       +8     
=======================================
+ Hits           66    69       +3     
- Misses         18    23       +5
Impacted Files Coverage Δ
src/IPython.jl 100% <ø> (ø) ⬆️
src/julia_repl.jl 53.33% <0%> (ø) ⬆️
src/convenience.jl 80.59% <100%> (-3.78%) ⬇️
src/core.jl 66.66% <57.14%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e75da4...6cf51b1. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 20, 2018

Pull Request Test Coverage Report for Build 81

  • 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.0%) to 80.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/julia_repl.jl 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/convenience.jl 5 67.16%
Totals Coverage Status
Change from base Build 47: 2.0%
Covered Lines: 58
Relevant Lines: 72

💛 - Coveralls

@tkf tkf merged commit 6cf51b1 into master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants