Resolve bug in which filtering the inline bookmarks pane always fails #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code resolves the problem in which filtering the inline bookmarks pane always fails. The cause was the filtering logic. When RegExp filters were present, they were being tested against branch nodes (i.e., the filenames), not just against the leaf nodes (i.e., the actual bookmark notes). The current code resolves this by doing two things: - Only perform the RegExp check against leaf nodes, passing the branch nodes through - To eliminate branch nodes with no matching children, call the underlying data model instance for every passed node to see if any of its children match and in that case, do filter it out. Regarding performance and correctness, in my tests, not provided here, I checked multiple bookmark types across multiple files and it worked without any glitches and very quickly for a moderate-sized workspace. With apologies, I do not have time to provide test cases for either accuracy or performance. However, the issue is resolved with this commit and the extension is now usable again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code resolves the problem in which filtering the inline bookmarks pane always fails.
The cause was the filtering logic. When RegExp filters were present, they were being tested against branch nodes (i.e., the filenames), not just against the leaf nodes (i.e., the actual bookmark notes).
The current code resolves this by doing two things:
Only perform the RegExp check against leaf nodes, passing the branch nodes through
To eliminate branch nodes with no matching children, call the underlying data model instance for every passed node to see if any of its children match and in that case, do filter it out.
Regarding performance and correctness, in my tests, not provided here, I checked multiple bookmark types across multiple files and it worked without any glitches and very quickly for a moderate-sized workspace. With apologies, I do not have time to provide test cases for either accuracy or performance. However, the issue is resolved with this commit and the extension is now usable again.