Add source map building in webpack and expose them to chrome #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhurjaty
commented
Nov 7, 2024
| "web_accessible_resources": [ | ||
| { | ||
| "resources": ["dist/src/*.js.map"], | ||
| "matches": ["<all_urls>"] |
There was a problem hiding this comment.
Excessively permissive, but shouldn't be a big problem for now. We should follow up at some point to lock this down a bit more
|
I tested locally and it works for me. Note that I thought it wasn't working at first because I didn't see the sourcemap in Chrome Dev Tools > Sources > Content Scripts, but then I realized it's contained under the directory Also, I recognize we're moving fast and ignoring most security concerns, so I made this issue to remind us later to do a security review: #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source maps to the build folder to make debugging easier. Chrome dev tools looks like this now: