Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for prettier 3 #1

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix tests for prettier 3 #1

merged 1 commit into from
Aug 10, 2023

Conversation

seanCodes
Copy link

This fixes the testing issues for prettier#901 (the PR to the upstream repo that adds support for prettier 3).

I think merging this will automatically update that PR to include the changes as well, so hopefully it can get merged itself now that the test issues are resolved.

Changes:

  • Update jest so that the dynamic import() in prettier 3 will be handled correctly when running tests
  • Update test scripts to include the node --experimental-vm-modules flag
  • Update babel and some other dev dependencies for good measure
  • Fix some typos

This fixes the testing issues for the PR to the upstream repo: prettier#901
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
babel-jest 25.5.1...29.6.2 None +16/-106 889 kB simenb
jest 25.5.4...29.6.2 None +75/-241 3.56 MB simenb
jest-cli 25.5.4...29.6.2 None +74/-240 3.56 MB simenb

@seanCodes
Copy link
Author

@timdp Friendly bump, whenever you have a sec

@timdp timdp merged commit 50a0452 into timdp:prettier-3 Aug 10, 2023
@timdp
Copy link
Owner

timdp commented Aug 10, 2023

Thank you! 👍

@seanCodes seanCodes deleted the prettier-3 branch August 14, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants