Divide CI in separate jobs #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
force-pushed
the
ci_checkhashes_in_new_job
branch
from
d7fc75a to
77ee33e
Compare
- Gives a better overview of CI and the different checks, without going into the logs too deeply. - Cache: use a unique key for each run, and remove 'restore key' since it could potentially retrieve the wrong bitstream. The stragegy should be to fail if a cache is not present, not fetch a bitstream from a different build.
dehanj
force-pushed
the
ci_checkhashes_in_new_job
branch
from
77f0d13 to
a5e30f1
Compare
This was referenced Apr 19, 2024
Merged
mchack-work
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide CI in separate jobs, categorized a bit better.
Cache: Fixed a bug and also fixed a potential issue with the cache strategy, where it could lead to the wrong bitstream being fetched if the original key was not found. This is solved now, now each and every run will create a unique key, and if the cache for some reason fails, the check-hash will fail instead of fetching a different bitstream.