Memory map constants as defines #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secworks
approved these changes
Mar 5, 2024
dehanj
reviewed
Mar 13, 2024
There was a problem hiding this comment.
The addresses seems to be correct, just a few comments on inconsistency. For example if we have the *_BASE included or not. Should they be included? I guess they are not used anymore since the prime usage before was to derive the addresses for a particular module.
|
We actually don't know if someone is using |
mchack-work
force-pushed
the
memory_map
branch
5 times, most recently
from
7424098 to
3725d03
Compare
dehanj
approved these changes
Mar 19, 2024
Instead of putting memory constant into an enum we use defines. Use the direct memory address instead of ORing constants together to compute the address. An enum in ISO C is a signed int. Some of are memory addresses are to large to fit in a signed int. This is not a problem since we're not using ISO C (-std=gnu99) but it doesn't look very nice if you turn on pedantic warnings. Also, if someone would use another compiler which at least supports the inline assembly we use, but possible not other GNU extensions, things would probably break.
Use pedantic warnings but still allow inline assembly, so turn off language-extension-token warnings.
|
Rebased on main, and removed a trailing whitespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning on
-W pedanticshows us that our memory constants can't fit in an enum in ISO C. Not a real problem for GNU99 but makes it hard to run-W pedanticto find other problems.I propose we change the memory constants from an enum into pre-processor defines instead and use simple direct values for the memory addresses instead of computing them.
We also turn on pedantic warnings but allow inline asm as the GNU extension we mostly use and fix missing void parameter declarations that pedantic warned us about.
Please review carefully that have all the addresses defined.
Also note that
tk1_mem.his also used intkey-libsandqemu.Closes #159