fix: handle potentially unaligned frame pointer #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen-xu
force-pushed
the
gen/fix_misaligned_dereference
branch
2 times, most recently
from
9ae5a39 to
d715918
Compare
|
@YangKeao this is an important PR that prevents using pprof-rs with frame pointer unwinding, could you please approve it? |
|
Sorry for the late reply and thanks for your contribution! Once you signed-off the commit, I'll merge this pull request ❤️ . You could sign-off through |
Signed-off-by: Gen Xu <[email protected]>
gen-xu
force-pushed
the
gen/fix_misaligned_dereference
branch
from
d715918 to
74664c5
Compare
|
@YangKeao just signed off |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addressed the issue #216