Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment of SuspendTime #1057

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Fix comment of SuspendTime #1057

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d08b582
comment: fix comment in TimeDetail
ekexium Nov 13, 2023
616154c
comment: refine comment of KvReadWallTime
ekexium Nov 13, 2023
96e0ac2
Merge branch 'master' into fix-comment-suspendtime
disksing Nov 14, 2023
2912cb6
Merge branch 'master' into fix-comment-suspendtime
disksing Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions util/execdetails.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,12 +609,13 @@ type TimeDetail struct {
// cannot be excluded for now, like Mutex wait time, which is included in this field, so that
// this field is called wall time instead of CPU time.
ProcessTime time.Duration
// Cpu wall time elapsed that task is waiting in queue.
// Time elapsed when a coprocessor task yields itself.
SuspendTime time.Duration
// Off-cpu wall time elapsed in TiKV side. Usually this includes queue waiting time and
// other kind of waits in series.
WaitTime time.Duration
// KvReadWallTime is the time used in KV Scan/Get.
// KvReadWallTime is the time used in KV Scan/Get. For get/batch_get,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// KvReadWallTime is the time used in KV Scan/Get. For get/batch_get,
// KvReadWallTime is the time used in KV Scan/Get. For coprocessor requests,

Coprocessor request queue time is more notable due to reschedule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was that for get/batch_get, the field covers more procedures

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo, you are right.

// this is total duration, which is almost the same with grpc duration.
KvReadWallTime time.Duration
// TotalRPCWallTime is Total wall clock time spent on this RPC in TiKV.
TotalRPCWallTime time.Duration
Expand Down