-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support profile parameters in pull & clone command #28
feat: support profile parameters in pull & clone command #28
Conversation
06c0b96
to
e8691c3
Compare
c53468f
to
b3771c3
Compare
65c81f9
to
e3ce816
Compare
I had a discussion with Pete, the implementation in this PR actually introduces easy-to-use features. That says However, let's see an edge case here, assuming:
In the implementation in this PR, it can be explained as
A noticeable thing in the step 2 is that internal merging/rebasing process is based on the scope of profile A. What if profile A is deleted in master branch? Or profile A cannot be correctly checkout enough folders when merging/rebasing. In this edge case, the sparo checkout folders are somehow inefficient during merging/rebasing from A more intuitive way for this is merging/rebasing from To this PR,
|
Got, I will disable pull command for now and merge this PR first. |
Got, I will revert the changes in pull command and merge this PR first. |
1 similar comment
Got, I will revert the changes in pull command and merge this PR first. |
Basic Checks
Have you run
rush change
for this change?Does this PR introduce a breaking change? (check one)
Summary
Support profile related parameters in pull & clone command
Detail
ensureSkeletonExistAndUpdated
inGitSparseCheckoutService
to avoid duplicated initialization for skeleton.resolveSparoProfileAsync
function was moved toSparoProfileService
preprocessProfileArgs
andsyncProfileState
inSparoProfileService
for code sharing.Notice:
Unlike
sparo checkout
command, clone and pull command will invoke native git command first and try to get profile in local file system.How to test it
Manually tested.