Insert media queries to style tag in the head of the document when the sources css makes use of them. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Nov 5, 2019
stof
requested changes
Nov 7, 2019
|
Abandoned feature ? It would be useful. |
|
It would be really useful. BTW, Emogrifier has it. |
stof
reviewed
Mar 21, 2023
| $docNode = $document->documentElement; | ||
| $head = $document->createElement('head'); | ||
| $head->appendChild($style); | ||
| $docNode->insertBefore($head, $docNode->firstChild); |
There was a problem hiding this comment.
isn't this broken if the HML has a <html> tag without a <head> tag ? An absent <head> tag does not only happen in partials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css media queries were filtered out (which makes sense as they're not supported as inline style), now that more and more clients support style tags in the head it makes sense to include them there when the source css contains them.