Add parallel signing of images to main pipeline #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrirosten
reviewed
Nov 4, 2024
Signed-off-by: Joonas Rautiola <[email protected]>
joinemm
force-pushed
the
pr-parallel-signing
branch
from
00d19dc to
70edd59
Compare
|
LGTM, assuming this has been tested properly. |
henrirosten
approved these changes
Nov 4, 2024
vjuntunen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function created in utils as the existing functions make too many assumptions and do too many things (and as such would not work in a parallel environment)