Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TCP DNS queries to kube-dns in the default deny policy #1096

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

wallrj
Copy link
Contributor

@wallrj wallrj commented Nov 15, 2023

In cert-manager/website#1344 (comment) we're discussing whether the default Calico deny policy should also allow TCP DNS queries.

Is there a reason to block them?

Fixes: projectcalico/calico#8224

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

In cert-manager/website#1344 (comment) we're discussing whether the default Calico deny policy should also allow TCP DNS queries.

Is there a reason to block them?
@wallrj wallrj requested a review from a team as a code owner November 15, 2023 10:18
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 487f2e8
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65549b02c6f8eb000843c126
😎 Deploy Preview https://deploy-preview-1096--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 15 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 487f2e8
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65549b021e607d0008ea107c
😎 Deploy Preview https://deploy-preview-1096--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 44 (🔴 down 28 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023

CLA assistant check
All committers have signed the CLA.

@ctauchen
Copy link
Collaborator

Thanks for the submission, @wallrj. This subject of this is out of scope for a docs-only discussion. The question isn't "How should we be documenting X?" so much as "How should we do/write/build X?"

I suggest you raise an issue with Project Calico and add link to this PR.

@wallrj
Copy link
Contributor Author

wallrj commented Nov 15, 2023

I suggest you raise an issue with Project Calico and add link to this PR.

Done:

Copy link
Member

@matthewdupre matthewdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better policy than the existing one.

@ctauchen
Copy link
Collaborator

LGTM

@ctauchen ctauchen mentioned this pull request Nov 21, 2023
5 tasks
@ctauchen ctauchen merged commit 9b1cd98 into tigera:main Nov 21, 2023
@wallrj wallrj deleted the patch-1 branch November 21, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Recommended default deny policy should allow DNS over TCP
4 participants