Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nebula_ros): fix flaky smoke test #260

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 4, 2025

PR Type

  • Improvement

Related Links

Description

#240 is flaky in CI but not on my local machine (works on my machine 🤡). This leads me to believe that it's a timing issue - Nebula might still be in its startup phase when it's interrupted by the test framework, resulting in a non-zero exit code.

This PR makes the test suite wait for the Wrapper=OK output before interrupting Nebula.

Review Procedure

Hope and pray.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

…aiting for known-good console output

Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex mojomex self-assigned this Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.14%. Comparing base (48d9ab9) to head (4f1cf58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   27.27%   27.14%   -0.14%     
==========================================
  Files         105      105              
  Lines        9465     9271     -194     
  Branches     2337     2057     -280     
==========================================
- Hits         2582     2517      -65     
+ Misses       6435     6334     -101     
+ Partials      448      420      -28     
Flag Coverage Δ
differential 27.14% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex
Copy link
Collaborator Author

mojomex commented Feb 4, 2025

Since CI takes ~10min per build/test cycle, there's no good way to test if flakiness is gone. Going ahead and merging.

@mojomex mojomex merged commit 44e6c88 into main Feb 4, 2025
11 of 12 checks passed
@mojomex mojomex deleted the test/fix-flaky-smoke-tests branch February 4, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant