clip now works like legato in tidal #598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clip so far was only a flag. now it supports floats, making it equivalent to legato in tidal.
i did not touch legato because it would break dozens of existing patterns, as legato currently works without hap.value, so it can be used within a control param function.
in the long run, it should make sense to either refactor old patterns or implement #288 .
with just clip changed, the only breaking change is that clip(0) now brings silence, instead of, as currently, disabling clip.
In practice, clip(0) is not really in use, as it is the default behavior anyway (i haven't found a single use anywhere)
btw shoutout to henk from the workshop for inspiring the idea!