Merge pull request #938 from tidalcycles/pianoroll-sorting

fix: pianoroll sorting
tidalcycles · Jan 24, 2024 · dd64bf0 · dd64bf0
2 parents 8fef753 + 434eb3b
commit dd64bf0
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/core/pianoroll.mjs b/packages/core/pianoroll.mjs
@@ -160,8 +160,13 @@ export function pianoroll({
     maxMidi = max;
     valueExtent = maxMidi - minMidi + 1;
   }
-  // foldValues = values.sort((a, b) => a - b);
-  foldValues = values.sort((a, b) => String(a).localeCompare(String(b)));
+  foldValues = values.sort((a, b) =>
+    typeof a === 'number' && typeof b === 'number'
+      ? a - b
+      : typeof a === 'number'
+        ? 1
+        : String(a).localeCompare(String(b)),
+  );
   barThickness = fold ? valueAxis / foldValues.length : valueAxis / valueExtent;
   ctx.fillStyle = background;
   ctx.globalAlpha = 1; // reset!