renamed linktest executable

[sss-create]

This would resolve issue #1041.... I just don't know if this would break anything. I assume it won't but still.. -- hence the PR and no direct push. 😶‍🌫️

[yaxu]

I don't see why this would be a problem, but @Zalastax will be more familiar with it

[yaxu]

BTW I think best we do PRs for everything anyway, even when you merge yourself, not least because it makes release notes easier.

[sss-create]

Ok, got it :)

While we're at it: Do we need to host the Ableton Link code ourselves here or could we reference the ableton repo as a submodule (with a specific commit)? Maybe @Zalastax can answer this too.

[Zalastax]

The renaming should be fine.

I used submodules originally but we changed to use file copy: #891 (comment)

I don't see much benefit to change back to submodules but I think it might be time to update the files.

[sss-create]

The benefits I see are:

• get rid of 500k lines of C++ code we don’t edit or directly need to work with
• make more visible that tidal-link depends on the link repo
• don’t have to manually update the files
• make the overall Tidal repo code (I assume) get rid of the ~90% C++ code indicator, which made me question if Tidal was really written in Haskell

However submodules are or can be fiddly, that‘s true. Plus, I am not sure what kind of effect using submodules would have on packaging/uploading tidal-link on hackage and the build process.

[yaxu]

No strong feelings either way, but appreciate those benefits over fiddlyness.

I think we should keep up-to-date with upstream as much as possible, in the past we lost compatibility with new mac os versions due to being behind. I imagine that's easier to track with submodules. I think fine to go ahead if you want to try it @sss-create.