Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9.5 bump #1071

Merged
merged 4 commits into from
Apr 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add most recent PR to changelog and finish contributing instructions
matthewkaney committed Apr 6, 2024
commit d80b501826f6e8c59bfdb8141f4e25ca5f54cd0a
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

## 1.9.5 - Sashiko

### What's Changed
## What's Changed
* avoid loading stream module in other modules, so hint wont crash by @polymorphicengine in https://github.com/tidalcycles/Tidal/pull/1019
* change streamGetnow to factor in the processAhead and also destroy the sessionstate by @polymorphicengine in https://github.com/tidalcycles/Tidal/pull/1025
* fix minor7sharp9 chord (the 9th wasn't sharp) by @cleary in https://github.com/tidalcycles/Tidal/pull/1036
@@ -11,10 +11,12 @@
* Update link 1.9 dev by @yaxu in https://github.com/tidalcycles/Tidal/pull/1058
* More build fixes by @mindofmatthew in https://github.com/tidalcycles/Tidal/pull/1062
* Consolidate site docs into source docs, and some docs editing by @trespaul in https://github.com/tidalcycles/Tidal/pull/1070
* Fix negative numbers not working for boolean euclids by @geikha in https://github.com/tidalcycles/Tidal/pull/1063

### New Contributors
## New Contributors
* @ahihi made their first contribution in https://github.com/tidalcycles/Tidal/pull/1046
* @trespaul made their first contribution in https://github.com/tidalcycles/Tidal/pull/1070
* @geikha made their first contribution in https://github.com/tidalcycles/Tidal/pull/1063

**Full Changelog**: https://github.com/tidalcycles/Tidal/compare/v1.9.4...v1.9.5

13 changes: 10 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -87,6 +87,8 @@ To run up your changes locally, install Tidal with `cabal install`. To remove th

*Note: This may be incomplete—before making a release, it's a good idea to reach out to an existing project maintainer to double-check the process.*

First, you'll need to figure out the new version number. Tidal follows the [Haskell Package Versioning Policy](https://pvp.haskell.org/)—basically, for a given version (e.g. `v1.0.0`), only update the last number if you're releasing a minor, non-breaking change (so a bug fix release might be `v1.0.1`). A major release requires editing the first or second numbers (so a major release that substantially adds or changes functionality might be `v1.1.0`, and a release that rearchitects the fundamentals would be `v2.0.0`). Major releases include those that update dependencies to a new major release. It's also a good idea to do a major release for any bugfixes where performers have started using the "bug" for aesthetics.

## Get Permission
First, you need to do the following:

@@ -105,8 +107,9 @@ First, you need to do the following:
## Update the Repository

Push any final changes to the code, updating the following files:
* **[tidal.cabal](https://github.com/tidalcycles/Tidal/blob/1.10-dev/tidal.cabal)**: Changing the version field
* **[CHANGELOG.md](https://github.com/tidalcycles/Tidal/blob/1.10-dev/CHANGELOG.md)**: Adding your new version at the top (you can copy the release notes from your draft GitHub release)
* **[tidal.cabal](https://github.com/tidalcycles/Tidal/blob/1.10-dev/tidal.cabal)**: Change the version field
* **Outdated Dependencies:** Run `cabal update` then `cabal outdated` to determine whether any of Tidal's dependencies are out of date, then update those as well
* **[CHANGELOG.md](https://github.com/tidalcycles/Tidal/blob/1.10-dev/CHANGELOG.md)**: Add your new version at the top (you can copy the release notes from your draft GitHub release)
* **[src/Sound/Tidal/Version.hs](https://github.com/tidalcycles/Tidal/blob/1.10-dev/src/Sound/Tidal/Version.hs)**: Update the version string here too. This is the version that's printed to the console when someone starts Tidal.
* **If any of the other packages (e.g. tidal-link) have changed**: Update the respective **.cabal** files for these packages, and then update dependency information in **tidal.cabal** as needed.

@@ -117,4 +120,8 @@ Push any final changes to the code, updating the following files:
* Run `cabal check` to check for any errors with the package metadata.
* Run `cabal sdist` to generate an archive for distribution.

## Upload releases
## Upload and Test Releases

* [The Hackage upload page](https://hackage.haskell.org/upload) contains instructions and links for uploading a release archive. **Start by uploading a package candidate because a package release can't be changed!**
* To distribute a package candidate for testing, find the download link for the `.tar.gz` bundle on the Hackage page for the package candidate. This candidate version can be installed with the following command: `cabal v1-install [url]` (note that at this time, [the v1 install command is necessary for installing a library from a URL](https://github.com/haskell/cabal/issues/8335)).
* Once everyone is happy with the new version, go ahead and upload the archive as a package release and publish the release on GitHub!

Unchanged files with check annotations Beta

where q st =
catMaybes $
concatMap
(\oe@(Event oc (Just jow) op ov) ->

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal latest - ghc latest

Pattern match(es) are non-exhaustive

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal latest - ghc latest

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Pattern match(es) are non-exhaustive

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’

Check warning on line 246 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’
map (\oe@(Event ic (iw) ip iv) ->

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal latest - ghc latest

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal latest - ghc latest

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

This binding for ‘oe’ shadows the existing binding

Check warning on line 247 in src/Sound/Tidal/Pattern.hs

GitHub Actions / build (9.0.1, 3.4.0.0)

Defined but not used: ‘oe’
do w <- subMaybeArc (Just jow) iw
p <- subArc op ip
return $ Event (combineContexts [ic, oc]) w p iv
_fastB =
[ bgroup "_fast" [
bench "_fast < 0" $ whnf (_fast (-2)) pattApp2
, bench "_fast > 0" $ whnf (_fast (toTime $ 10^6)) (cat catPattBig) ]

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal latest - ghc latest

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal latest - ghc latest

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

• Defaulting the following constraints to type ‘Integer’

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

• Defaulting the type variable ‘a0’ to type ‘Integer’ in the following constraints

Check warning on line 12 in bench/Speed/Tidal/CoreB.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

• Defaulting the type variable ‘b0’ to type ‘Integer’ in the following constraints
]
concatB :: [Benchmark]
import Tidal.Inputs
import Sound.Tidal.Pattern
arc1 = Arc 3 5

Check warning on line 7 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Top-level binding with no type signature: arc1 :: ArcF Time

Check warning on line 7 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Top-level binding with no type signature: arc1 :: ArcF Time

Check warning on line 7 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Top-level binding with no type signature: arc1 :: ArcF Time

Check warning on line 7 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Top-level binding with no type signature: arc1 :: ArcF Time

Check warning on line 7 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Top-level binding with no type signature: arc1 :: ArcF Time
arc2 = Arc 4 6

Check warning on line 8 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Top-level binding with no type signature: arc2 :: ArcF Time

Check warning on line 8 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Top-level binding with no type signature: arc2 :: ArcF Time

Check warning on line 8 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Top-level binding with no type signature: arc2 :: ArcF Time

Check warning on line 8 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Top-level binding with no type signature: arc2 :: ArcF Time

Check warning on line 8 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Top-level binding with no type signature: arc2 :: ArcF Time
arc3 = Arc 0 1

Check warning on line 9 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Top-level binding with no type signature: arc3 :: ArcF Time

Check warning on line 9 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Top-level binding with no type signature: arc3 :: ArcF Time

Check warning on line 9 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Top-level binding with no type signature: arc3 :: ArcF Time

Check warning on line 9 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Top-level binding with no type signature: arc3 :: ArcF Time

Check warning on line 9 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Top-level binding with no type signature: arc3 :: ArcF Time
arc4 = Arc 1 2

Check warning on line 10 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 9.0.1

Top-level binding with no type signature: arc4 :: ArcF Time

Check warning on line 10 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.4.4

Top-level binding with no type signature: arc4 :: ArcF Time

Check warning on line 10 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.8.3

Top-level binding with no type signature: arc4 :: ArcF Time

Check warning on line 10 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.10.1

Top-level binding with no type signature: arc4 :: ArcF Time

Check warning on line 10 in bench/Speed/Tidal/PatternB.hs

GitHub Actions / cabal 3.4.0.0 - ghc 8.6.5

Top-level binding with no type signature: arc4 :: ArcF Time
withQueryTimeB :: [Benchmark]
withQueryTimeB =
transform _ _ = id
transform' str (Arc s e) p = s `rotR` inside (pure $ 1/(e-s)) (matchF str) p
matchF str = fromMaybe id $ lookup str fs
timedValues = withEvent (\(Event c (Just a) a' v) -> Event c (Just a) a' (a,v)) . filterDigital

Check warning on line 1861 in src/Sound/Tidal/UI.hs

GitHub Actions / cabal latest - ghc latest

Pattern match(es) are non-exhaustive

Check warning on line 1861 in src/Sound/Tidal/UI.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Pattern match(es) are non-exhaustive
{- | A simpler version of 'ur' that just provides name-value bindings that are
reflected in the provided pattern.
-- (but perhaps we should explicitly crash with an error message if it contains something else?).
-- Map.mapKeys tail is used to remove ^ from the keys.
-- In case (value e) has the key "", we will get a crash here.
playmap' = Map.union (Map.mapKeys tail $ Map.map (\(VI i) -> VS ('c':(show $ toBus i))) busmap) playmap

Check warning on line 358 in src/Sound/Tidal/Stream.hs

GitHub Actions / cabal latest - ghc latest

Pattern match(es) are non-exhaustive

Check warning on line 358 in src/Sound/Tidal/Stream.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Pattern match(es) are non-exhaustive
val = value . peEvent
-- Only events that start within the current nowArc are included
playmsg | peHasOnset pe = do
toBus n | null busses = n
| otherwise = busses !!! n
busmsgs = map
(\(('^':k), (VI b)) -> do v <- Map.lookup k playmap

Check warning on line 379 in src/Sound/Tidal/Stream.hs

GitHub Actions / cabal latest - ghc latest

Pattern match(es) are non-exhaustive

Check warning on line 379 in src/Sound/Tidal/Stream.hs

GitHub Actions / cabal 3.8.1.0 - ghc 9.4.1

Pattern match(es) are non-exhaustive
return $ (tsPart,
True, -- bus message ?
O.Message "/c_set" [O.int32 b, toDatum v]