Address review

ticheler · Sep 8, 2024 · e1709a3 · e1709a3
1 parent 5cd1e31
commit e1709a3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/resources/function_help/json/line_interpolate_point_by_m b/resources/function_help/json/line_interpolate_point_by_m
@@ -12,6 +12,7 @@
   }, {
     "arg": "use_3d_distance",
     "optional": true,
+    "default": "false",
     "description": "controls whether 2D or 3D distances between vertices should be used during interpolation (this option is only considered for lines with z values)"
   }],
   "examples": [{

diff --git a/resources/function_help/json/line_locate_m b/resources/function_help/json/line_locate_m
@@ -12,6 +12,7 @@
   }, {
     "arg": "use_3d_distance",
     "optional": true,
+    "default": "false",
     "description": "controls whether 2D or 3D distances between vertices should be used during interpolation (this option is only considered for lines with z values)"
   }],
   "examples": [{

diff --git a/src/core/expression/qgsexpressionfunction.cpp b/src/core/expression/qgsexpressionfunction.cpp
@@ -5655,7 +5655,7 @@ static QVariant fcnLineInterpolatePoint( const QVariantList &values, const QgsEx
 
 static QVariant fcnLineInterpolatePointByM( const QVariantList &values, const QgsExpressionContext *, QgsExpression *parent, const QgsExpressionNodeFunction * )
 {
-  QgsGeometry lineGeom = QgsExpressionUtils::getGeometry( values.at( 0 ), parent );
+  const QgsGeometry lineGeom = QgsExpressionUtils::getGeometry( values.at( 0 ), parent );
   const double m = QgsExpressionUtils::getDoubleValue( values.at( 1 ), parent );
   const bool use3DDistance = values.at( 2 ).toBool();
 
@@ -5761,7 +5761,7 @@ static QVariant fcnLineLocatePoint( const QVariantList &values, const QgsExpress
 
 static QVariant fcnLineLocateM( const QVariantList &values, const QgsExpressionContext *, QgsExpression *parent, const QgsExpressionNodeFunction * )
 {
-  QgsGeometry lineGeom = QgsExpressionUtils::getGeometry( values.at( 0 ), parent );
+  const QgsGeometry lineGeom = QgsExpressionUtils::getGeometry( values.at( 0 ), parent );
   const double m = QgsExpressionUtils::getDoubleValue( values.at( 1 ), parent );
   const bool use3DDistance = values.at( 2 ).toBool();