Update Dialog to use children #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
approved these changes
Nov 15, 2023
apps/cyberstorm-storybook/stories/components/Dialog.stories.tsx
Outdated
Show resolved
Hide resolved
...rm/src/components/Layout/PackageDetailLayout/PackageManagementForm/PackageManagementForm.tsx
Outdated
Show resolved
Hide resolved
packages/cyberstorm/src/components/Layout/Teams/TeamSettings/TeamMembers/TeamMemberList.tsx
Outdated
Show resolved
Hide resolved
packages/cyberstorm/src/components/Layout/Teams/TeamSettings/TeamMembers/TeamMembers.module.css
Outdated
Show resolved
Hide resolved
packages/cyberstorm/src/components/Layout/Teams/TeamSettings/TeamMembers/TeamMembers.tsx
Outdated
Show resolved
Hide resolved
...ents/Layout/Teams/TeamSettings/TeamServiceAccounts/ServiceAccountList/ServiceAccountList.tsx
Show resolved
Hide resolved
Oksamies
force-pushed
the
dialog-update
branch
from
590086d to
f193c39
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anttimaki
requested changes
Nov 16, 2023
| import { PackageDependencyDialog } from "./PackageDependencyDialog/PackageDependencyDialog"; | ||
| import * as Button from "../../../Button/"; | ||
| import { useDapper } from "@thunderstore/dapper"; | ||
| import { usePromise } from "@thunderstore/use-promise"; | ||
| import { Dialog } from "../../../.."; |
There was a problem hiding this comment.
The latest changes brought multiple of these import back the PR. IDK if the tooling for autoimports could be improved to resolve this. Until then I'd prefer we'd fix these manually. Not a blocker though.
There was a problem hiding this comment.
Seems they are not all fixed yet.
Oksamies
force-pushed
the
dialog-update
branch
2 times, most recently
from
3c1095e to
5ae34bd
Compare
refs TS-1955
refs TS-1955
Oksamies
force-pushed
the
dialog-update
branch
from
5ae34bd to
d5b9ea5
Compare
anttimaki
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TS-1955