@thunderstore/dapper-ts: improve error handling #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Oksamies
approved these changes
Nov 12, 2023
anttimaki
force-pushed
the
ts-api-error-handling
branch
from
888091a to
b19e0c6
Compare
anttimaki
force-pushed
the
dapper-ts-error-handling
branch
from
5eb7bc1 to
c971dee
Compare
anttimaki
force-pushed
the
ts-api-error-handling
branch
from
b19e0c6 to
d3f18a5
Compare
anttimaki
force-pushed
the
dapper-ts-error-handling
branch
from
c971dee to
44c8d08
Compare
Sentry handling doesn't need to be done on package level since we're doing it on app level. Try to throw useful error messages, taking into account I don't how much of the error stack is available on Sentry or NextJs logs this way. Refs no ticket
anttimaki
changed the base branch from
ts-api-error-handling
to
dapper-ts-package-listing
anttimaki
force-pushed
the
dapper-ts-error-handling
branch
from
44c8d08 to
e30544f
Compare
|
This PR can't be merged since a PR earlier in the stack doesn't pass CI due to changes for backend, that would be accounted for in a PR later in the stack. The changes will be merged as a part of #915. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry handling doesn't need to be done on package level since we're
doing it on app level. Try to throw useful error messages, taking into
account I don't how much of the error stack is available on Sentry or
NextJs logs this way.
Refs no ticket