Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rounding and formatting with package data #890

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Oksamies
Copy link
Contributor

@Oksamies Oksamies commented Nov 7, 2023

Replace bankersRound with appropriate rounding methods Add formatFileSize for formatting file sizes correctly

refs #887

@Oksamies Oksamies requested a review from anttimaki November 7, 2023 11:05
Copy link
Contributor

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Replace bankersRound with appropriate rounding methods
Add formatFileSize for formatting file sizes correctly

refs #887
@Oksamies Oksamies force-pushed the package-size-formatter branch from 7d857d6 to 7808de7 Compare November 7, 2023 11:37
@Oksamies Oksamies merged commit 095815a into master Nov 7, 2023
17 checks passed
@Oksamies Oksamies deleted the package-size-formatter branch November 7, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants