Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@thunderstore/cyberstorm: drop obsolete FilterItemList component #888

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

anttimaki
Copy link
Contributor

@anttimaki anttimaki commented Nov 7, 2023

The component was superseded by different "FilterMenu" implementations
introduced from commit aae0ac3 onwards. I was supposed to remove the
old implementation when I was done refactoring, but forgot to do it. Or
maybe I did but the deletions got reverted while resolving merge
conflicts. Either way, it's time for FilterItems to go.

Refs TS-1860

@anttimaki
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

The component was superseded by different "FilterMenu" implementations
introduced from commit aae0ac3 onwards. I was supposed to remove the
old implementation when I was done refactoring, but forgot to do it. Or
maybe I did but the deletions got reverted while resolving merge
conflicts. Either way, it's time for FilterItems to go.

Refs TS-1860
@anttimaki anttimaki force-pushed the drop-filter-item-list branch from 5ff2992 to 65b05e8 Compare November 7, 2023 08:06
@anttimaki anttimaki merged commit 438d099 into master Nov 7, 2023
25 checks passed
@anttimaki anttimaki deleted the drop-filter-item-list branch November 7, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants