Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@thunderstore/dapper: use unique ids in category and section objects #884

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

anttimaki
Copy link
Contributor

No description provided.

While PackageCategory and PackageListingSection slugs are unique in a
community scope, they're not globally unique. To ensure more robust
behaviour, use the unique database ids internally.

Refs TS-1890
When filtering a package list, the ids of categories and uuids of
sections should be sent to backend, instead of the slugs, which are
guaranteed to be unique only within a scope of each community.

Refs TS-1890
@anttimaki
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@anttimaki anttimaki merged commit 4802b8f into master Nov 6, 2023
@anttimaki anttimaki deleted the dapper-filter-ids branch November 6, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants