Add ProfilePanel component #650
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oksamies
force-pushed
the
twitch-extension
branch
from
dac03a6 to
cf4bb06
Compare
anttimaki
reviewed
Apr 3, 2023
| flex-direction: column; | ||
| gap: var(--gap--12); | ||
| align-items: center; | ||
| width: 318px; |
There was a problem hiding this comment.
Very specific sizing, and not using rems. Is this something that Twitch requires?
There was a problem hiding this comment.
Yeah, they have a fixed max size for the panels 👍
| const { profile } = props; | ||
|
|
||
| return ( | ||
| <div className={styles.root}> |
There was a problem hiding this comment.
Why is everything a div :(
| <div className={styles.content}> | ||
| {profile.mods.map(function (mod, i) { | ||
| return ( | ||
| <div key={String(i)} className={styles.modrow}> |
There was a problem hiding this comment.
Mod name, or combination of name and version would be a better key. Although the data currently passed to Storybook is a bit 💩 in that regard.
| <div className={styles.modName}>{mod.name}</div> | ||
| <div className={styles.modVersion}>{mod.version}</div> | ||
| </div> | ||
| <a className={styles.modLink} href={mod.url}> |
There was a problem hiding this comment.
Would be be more user-friendly if the whole .modrow acted as a link instead of just the icon?
| @@ -10,6 +10,7 @@ export * from "./components/Links/Links"; | |||
| export * from "./components/MenuItem/MenuItem"; | |||
| export * from "./components/MetaItem/MetaItem"; | |||
| export * from "./components/PackageCard/PackageCard"; | |||
| export * from "./components/ProfilePanel/ProfilePanel"; | |||
There was a problem hiding this comment.
Would "ProfileEmbed" oslt be a better name?
Oksamies
force-pushed
the
twitch-extension
branch
2 times, most recently
from
43b90d0 to
1da8262
Compare
This will be used by the twitch panel extension refs -
refs TS-1656 TS-1658
Oksamies
force-pushed
the
twitch-extension
branch
from
1da8262 to
585d40e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by the twitch panel extension
refs -