Package Detail page versions tab #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Oksamies
force-pushed
the
01-03-package_detail_page_versions_tab
branch
from
981a958 to
bc0f143
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+102
to
+115
| function compare(a: TableRow, b: TableRow) { | ||
| const column = sortVariables.identifier; | ||
| if (a[column] && b[column] && a[column].sortValue < b[column].sortValue) { | ||
| return sortVariables.direction; | ||
| } | ||
| if (a[column] && b[column] && a[column].sortValue > b[column].sortValue) { | ||
| return -sortVariables.direction; | ||
| } | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
The compare() function's logic appears reversed. Currently sortVariables.direction is returned when a < b and -sortVariables.direction when a > b, which will produce the opposite of the intended sort order. To fix this, swap the return values - return -sortVariables.direction for a < b and sortVariables.direction for a > b.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Oksamies
force-pushed
the
01-03-package_detail_page_versions_tab
branch
from
bc0f143 to
fa8cc82
Compare
Oksamies
force-pushed
the
01-03-package_detail_page_versions_tab
branch
from
fa8cc82 to
216ea18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.