Cyberstorm API: improve sorting on team-related list views #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
===========================================
- Coverage 92.27% 65.30% -26.97%
===========================================
Files 271 271
Lines 7820 7820
Branches 743 743
===========================================
- Hits 7216 5107 -2109
- Misses 502 2638 +2136
+ Partials 102 75 -27
☔ View full report in Codecov by Sentry. |
Based on non-blocking review comment, Mythic has apparently had some issues with DRF's stock OrderingFilter, so use the home brewed StrictOrderingFilter instead. Refs TS-1856
anttimaki
force-pushed
the
team-listviews-sorting
branch
from
b5bbcf3 to
ba10602
Compare
|
I've no idea what codecov is complaining about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cyberstorm API: add tests for sorting team-related list views
Refs TS-1856
Cyberstorm API: use StrictOrderingFilter on team-related list views
Based on non-blocking review comment, Mythic has apparently had some
issues with DRF's stock OrderingFilter, so use the home brewed
StrictOrderingFilter instead.
Refs TS-1856