120 connect damo exporter #178
Conversation
| def export_damo_and_hydamo(self): | ||
| """Handle export of DAMO and HyDAMO.""" | ||
| file_path = self.dockwidget.SelectPolderFileWidget.filePath() | ||
| damo_gpkg_path = os.path.join(self.project.project_folder, "01_source_data", "DAMO.gpkg") |
There was a problem hiding this comment.
dit zou al in de folderstructuur moeten staan. Dus hier;
self.project.project_folder.source_data.damo
|
|
||
| # Load GeoPackage layers into QGIS | ||
| try: | ||
| damo_gpkg_path = os.path.join(self.project.project_folder, "01_source_data", "DAMO.gpkg") |
There was a problem hiding this comment.
tweede keer declaren zelfde variabele?
| if file_path: | ||
| # DAMO export | ||
| gdf_polder = gpd.read_file(file_path) | ||
| dict_gdfs_damo = DAMO_exporter(gdf_polder, TABLE_NAMES) |
There was a problem hiding this comment.
Zie review Wouter htt. Lijkt me beter om opslaan per tabel te doen?
Daarnaast lijkt me dit functionaliteit die je in htt wilt hebben en niet in de plugin.
| - CreateProjectPushButton : QPushButton | ||
| - SchematisationBuilderVerticalSpacer : Spacer | ||
| - ProjectTabWidget : QTabWidget | ||
| - tab_status_0 : QWidget |
There was a problem hiding this comment.
Zonder het gezien te hebben, is deze naam beschrijvend genoeg?
|
|
||
| from hhnk_threedi_plugin.hhnk_toolbox_dockwidget import HHNK_toolboxDockWidget | ||
|
|
||
| BASE_FOLDER = r"\\corp.hhnk.nl\data\Hydrologen_data\Data\09.modellen_speeltuin" |
There was a problem hiding this comment.
Dit lijkt niet hier thuis te horen maar in een local_settings of ergens anders?
|
|
||
| def populate_combobox(self): | ||
| """Populate the combobox with folder names from the base folder.""" | ||
| if os.path.exists(BASE_FOLDER): |
There was a problem hiding this comment.
liefst zoveel mogelijk pathlib.Path gebruiken.
| ### Stap 0. Een project beginnen of een bestaand project verder oppakken | ||
|
|
||
|
|
||
| ... plaatje UI volgt later na evt wijzigingen adhv sprint review |
There was a problem hiding this comment.
Todo's graag opnemen met # TODO
| self.dockwidget.CreateProjectPlainTextEdit.clear() | ||
| QPlainTextEdit.focusInEvent(self.dockwidget.CreateProjectPlainTextEdit, event) | ||
|
|
||
| def load_layers_from_geopackage(self, geopackage_path, group_name): |
There was a problem hiding this comment.
| def on_project_selected(self): | ||
| """Handle project selection from the combo box.""" | ||
| selected_folder = self.dockwidget.SelectProjectComboBox.currentText() | ||
| full_path = os.path.join(BASE_FOLDER, selected_folder) |
There was a problem hiding this comment.
Path(BASE_FOLDER).joinpath(selected_folder)
| selected_folder = self.dockwidget.SelectProjectComboBox.currentText() | ||
| full_path = os.path.join(BASE_FOLDER, selected_folder) | ||
| self.project = Project(full_path) | ||
| self.project_status = self.project.retrieve_project_status() |
There was a problem hiding this comment.
gelijk aan self.project.project_status? Ook daar project.status logischer?
Wat zijn de mogelijke waarden van project_status? Is daar ergens domeintabel van?
Die retrieve_project_status zoals die nu in htt staat lijkt erop dat een @property handiger is?
@property
def status(self):
return self._status
Nu werkend voor lagen: duikersifonhevel en hydroobject
GUI voor project beginnen / hervatten en exporteren van DAMO obv van poldergrenzen