This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Add responsive styles to announcement subscribe button #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysongach
approved these changes
Sep 23, 2019
|
@tysongach All set with this PR but have you noticed that a test started failing on CI (see this Circle build)? Same for #748, #750, and #751. Oddly I cannot reproduce it locally - that test passes fine. Any thoughts on what that's all about? |
|
@WilHall Seem like a flaky test maybe - some of those PRs you linked to are now passing, others still failing. It looks like maybe a Markdown parser issue? It’s perhaps escaping HTML differently? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678.
Adds responsive styles to the announcement subscribe button so that it doesn't squish the author.
Portrait
Landscape