Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in Markdown lists and definitions #22

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

DervexDev
Copy link
Contributor

@DervexDev DervexDev commented Mar 18, 2024

Closes #9.

This PR makes changelogs generated by this action 100% accurate with Keep a Changelog format.

Before:

...

## [0.2.0] - 2019-09-13

### Added

-   First feature that is gonna make us money.
-   Quite a few bugs, sorry in advance!

### Changed

-   Reworked the login system. You have to provide a password now!

## [0.1.0] - 2019-09-05

### Added

-   Initial release :tada:

[Unreleased]: https://github.com/foo/bar/compare/0.2.0...HEAD

[0.2.0]: https://github.com/foo/bar/compare/0.1.0...0.2.0

[0.1.0]: https://github.com/foo/bar/compare/1625533e04119e8496b14d5e18786f150b4fce4d...0.1.0

After:

...

## [0.2.0] - 2019-09-13

### Added

- First feature that is gonna make us money.
- Quite a few bugs, sorry in advance!

### Changed

- Reworked the login system. You have to provide a password now!

## [0.1.0] - 2019-09-05

### Added

- Initial release :tada:

[unreleased]: https://github.com/foo/bar/compare/0.2.0...HEAD
[0.2.0]: https://github.com/foo/bar/compare/0.1.0...0.2.0
[0.1.0]: https://github.com/foo/bar/compare/1625533e04119e8496b14d5e18786f150b4fce4d...0.1.0

I also formatted the code and made some minor improvements.

I would love this change to be released as soon as possible :)

@DervexDev DervexDev changed the title Fix spacing in Markdown lists and definitions, format code Fix spacing in Markdown lists and definitions Mar 20, 2024
Copy link
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, otherwise LGTM!

I'd appreciate if the re-formatting also comes with CI checks so we don't mess it up again.

src/updateChangelog.ts Outdated Show resolved Hide resolved
@DervexDev
Copy link
Contributor Author

I'd appreciate if the re-formatting also comes with CI checks so we don't mess it up again.

Added CI workflow that run tests.

Copy link
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot! :)

@DervexDev
Copy link
Contributor Author

Umm that's weird why does npm test fail? I was able to run tests with no problem on my machine.

@thomaseizinger
Copy link
Owner

Umm that's weird why does npm test fail? I was able to run tests with no problem on my machine.

I don't know what the default nodejs version is on GitHub. Might be worth using setup-node to be explicit.

@DervexDev
Copy link
Contributor Author

DervexDev commented Mar 28, 2024

Done!

I also had to ignore one TS error as it actually doesn't affect anything. Tests now work just fine and I was able to build action with no problems!

@thomaseizinger thomaseizinger merged commit 3b37022 into thomaseizinger:master Apr 8, 2024
1 check passed
@thomaseizinger
Copy link
Owner

Thank you very much! This is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Modified spacing for Markdown lists in the Changelog
2 participants