-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacing in Markdown lists and definitions #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request, otherwise LGTM!
I'd appreciate if the re-formatting also comes with CI checks so we don't mess it up again.
Added CI workflow that run tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot! :)
Umm that's weird why does |
I don't know what the default nodejs version is on GitHub. Might be worth using setup-node to be explicit. |
Done! I also had to ignore one TS error as it actually doesn't affect anything. Tests now work just fine and I was able to build action with no problems! |
Thank you very much! This is now released. |
Closes #9.
This PR makes changelogs generated by this action 100% accurate with Keep a Changelog format.
Before:
After:
I also formatted the code and made some minor improvements.
I would love this change to be released as soon as possible :)