-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route: add missing rtnl_nh_get_oif symbol #419
Conversation
I added them alongside the other rtnl_nh_* as that is when they were added, though I'm not sure if this is the right place to add them, or if they should be in
That took me a while to reproduce. So these functions actually don't exist. |
a845d4e
to
570be1d
Compare
Ah, a commit post 3.11 dropped the definitions, that explains it (started working on this based on 3.11). Dropped and updated. |
The linker symbols help with versioning. For example, RPM package dependencies automatically tracks when a certain package requires The correct solution is to add the symbols now to 3.12 because that is the next upcoming release. Add a new |
Well, one could do a 3_8_1 that fixes it ;P But unless that happens, I guess 3_12 is the next best thing. |
570be1d
to
520b1d5
Compare
When nh support was added in 780d06a ("route: add nh type"), rtnl_nh_get_oif() was missed adding to libnl-route-3.sym. Add the missing symbol so it can be actually used. Fixes: 780d06a ("route: add nh type") Signed-off-by: Jonas Gorski <[email protected]>
520b1d5
to
f752122
Compare
Yes, but I don't maintain a 3.8 stable branch, so we would never do a release that only brings If we would maintain old-stable branches then yes. Because then the set of |
Righto. Anyway, moved it to libnl3_12, and made it based on libnl3_11, not libnl3_10 *coughs*. |
When nh support was added in 780d06a ("route: add nh type"), rtnl_nh_get_oif() was missed adding to libnl-route-3.sym. Add the missing symbol so it can be actually used. Fixes: 780d06a ("route: add nh type") Signed-off-by: Jonas Gorski <[email protected]> #419
merged as 470c0a6 thank you!!! |
When nh support was added in 780d06a ("route: add nh type"), rtnl_nh_get_oif() was missed adding to libnl-route-3.sym.
Add the missing symbol so it can be actually used.
Fixes: 780d06a ("route: add nh type")