Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Docker image build #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

oberstet
Copy link
Contributor

@oberstet oberstet commented Nov 21, 2024

add docker files to build images for openEMS - see discussion #166

@thliebig
Copy link
Owner

thliebig commented Dec 9, 2024

As discussed at many places. I'm open for adding docker support (as long as it is optional only for those who want to use it), but this looks a long way from usable?
e.g.:

(.venv) oberstet@intel-nuci7:~/scm/typedefint/rfminer/docker$ make version_openems_from_upstream_all

Also this looks much more complicated than I though it should be?

@oberstet
Copy link
Contributor Author

oberstet commented Dec 9, 2024

Also this looks much more complicated than I though it should be?

this is my non-automated manual CLI based image baking, but any automation would reuse the same Dockerfiles, and that is actually what I had spent quite some time to get done already, so I'd love to preserve my time invest, help users, contribute!

we are in an endless loop;) sorry. please let me try one more time stating what I am not sure about / what I need from your side:


  1. would you (as a project owner / original author) support allowing users (not CI/CD or whatever) to do:
docker run jupyter/openems-notebook

that's all a user would need to do, users do NOT need to do anything else (no make or whatever)!

pls see for the general UX / other projects doing it

https://github.com/jupyter/docker-stacks
https://quay.io/organization/jupyter
https://docs.docker.com/guides/jupyter/

  1. would you (as a project owner / original author) claim a personal account and organization on Docker hub for openEMS?

  2. would you allow me to use the approach I know and am convinced of baking such images (built from vanilla upstream sources within the image) and publishing the images to Docker hub?

maybe I try to get openems-notebook into jupyter/docker-stacks .. not sure ... depends -- but again, official support from official/original author of openEMS is essential


if any answer is "nope", it is a waste of time for me, and I am pretty loaded, and I do have and use my manually built Docker images, so cool for me!

if all answers are "yes, go for it!", I would think about whether/when I can shelf out time to add a GitHub Actions workflow that does above fully lights out and automatic. I know how to do it, done it before (for other projects).

@thliebig
Copy link
Owner

As I have said elsewhere, I want openEMS to be as inclusive to all use-cases. Thus if someone want to use openEMS with/in docker like this, then YES we should do this and I will support it.
And yes I will then create a docker-hub account to make this possible. Anything I need to know about that?

How this dockerfile ultimately would look like is I guess then open for discussion but it would helpful if you could make a first suggestion. I hope this file could be much smaller and simpler as in this PR?

Additionally I think this should be done in the openEMS-Project which is kind of the "meta" project that is meant for supplying build scripts and such? I guess the docker build file might use the update_openEMS.sh script?
Do you agree that this means we can close this PR (after some more discussion if necessary)?

Would docker be able to support the Qt-GUI AppCSXCAD too (not mandatory I guess)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants