Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance unit-test #405

Merged
merged 6 commits into from
Feb 18, 2024
Merged

Enhance unit-test #405

merged 6 commits into from
Feb 18, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Feb 18, 2024 •
edited
Loading

Context

  • After the server fails to start, add docker logs palworld-server to view the logs.
  • Test if the address and password in the rcon.yaml correspond to RCON_PORT and ADMIN_PASSWORD in the .env.example.
  • Test if the rcon-cli works with Info, save, Broadcast commands.

Choices

Test instructions

  1. Push to the main branch and check each unit test step to ensure it meets the expected criteria.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit 46e685a into thijsvanloef:main Feb 18, 2024
9 checks passed
@win5923 win5923 deleted the unittest branch February 19, 2024 03:50
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
@thijsvanloef
Merge pull request thijsvanloef#405 from win5923/unittest
513495a 
Enhance unit-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@win5923 @thijsvanloef