-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to access their own DOB #10618
Allow user to access their own DOB #10618
Conversation
d751fcf
to
1f1a06e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxidragon. I agree with the changes. But since this is having changes in sensitive information, I prefer to get approval from @gregorbg.
Also, question that I genuinely don't know the answer to: |
Great catch. There is nothing wrong in providing, but it's currently not necessary. Maybe can we add just DOB for self users? WDYT @maxidragon? |
Yeah, it's not necessary, I'll modify the code to add just DOB for normal users |
@maxidragon Can I request for one more ask? Can you show the DOB for delegates as well? Delegate's edit profile form is also not populating the DOB. |
Yep, changed |
(Had to merge |
@danieljames-dj discovered that users cannot access their own DOB because it is restricted to WRT only. As a result, we (WRT) have received some empty forms, which were not actually empty. Users had entered the correct DOB, but after backend comparison, it was determined that there was no change, leading to an empty email notification.
In this PR, I've allowed users to access their own
private_attributes
, so their DOB will be prefilled in the edit profile form.