Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to access their own DOB #10618

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

maxidragon
Copy link
Member

@maxidragon maxidragon commented Jan 13, 2025

@danieljames-dj discovered that users cannot access their own DOB because it is restricted to WRT only. As a result, we (WRT) have received some empty forms, which were not actually empty. Users had entered the correct DOB, but after backend comparison, it was determined that there was no change, leading to an empty email notification.

In this PR, I've allowed users to access their own private_attributes, so their DOB will be prefilled in the edit profile form.

@maxidragon maxidragon force-pushed the edit-person-private-attributes branch from d751fcf to 1f1a06e Compare January 13, 2025 14:26
Copy link
Member

@danieljames-dj danieljames-dj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxidragon. I agree with the changes. But since this is having changes in sensitive information, I prefer to get approval from @gregorbg.

@gregorbg
Copy link
Member

gregorbg commented Jan 14, 2025

Also, question that I genuinely don't know the answer to:
Should users see their own incorrect_wca_id_claim_count? Because with this PR, they would. But I'm honestly not sure if that's a good thing.

@danieljames-dj
Copy link
Member

Also, question that I genuinely don't know the answer to: Should users see their own incorrect_wca_id_claim_count? Because with this PR, they would. But I'm honestly not sure if that's a good thing.

Great catch. There is nothing wrong in providing, but it's currently not necessary. Maybe can we add just DOB for self users? WDYT @maxidragon?

@maxidragon
Copy link
Member Author

Yeah, it's not necessary, I'll modify the code to add just DOB for normal users

@danieljames-dj
Copy link
Member

@maxidragon Can I request for one more ask? Can you show the DOB for delegates as well? Delegate's edit profile form is also not populating the DOB.

@maxidragon
Copy link
Member Author

@maxidragon Can I request for one more ask? Can you show the DOB for delegates as well? Delegate's edit profile form is also not populating the DOB.

Yep, changed

@gregorbg
Copy link
Member

(Had to merge main again to get rid of a very weird CI quirk. Nothing wrong with your code!)

@gregorbg gregorbg merged commit 9ace921 into thewca:main Jan 21, 2025
2 checks passed
@maxidragon maxidragon deleted the edit-person-private-attributes branch January 21, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants