Circumvent cache in WIC->Ethics sync #10588
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (unfortunately) a very obscure fix, because the use-case is already a hack in itself.
WIC is the first team ever (to my knowledge) where two teams were merged into one (originally WDC and WEC). They want access to the historic records in both email groups, but we only support one-to-one sync.
When WIC was introduced, it was decided that they will become a rename of WDC. So they have automatic stuff to all WDC history. But they also want and need to be synced to ethics@ which is the old WEC group. We do that sync manually with a hand-crafted line of code.
The problem is that this code directly accesses the
GroupsMetadataTeamsCommittees.wic
shorthand. These shorthands are cached, so if the leader adds new members the list sync will not consider them until the next deploy (or reboot) which can sometimes be days apart.This PR fixes that small inconvenience by using
pluck
which forces Rails to directly fire an SQL query every single time.