Bump rubocop from 1.69.2 to 1.70.0 (#10608)

thewca · Jan 13, 2025 · 3fb0de0 · 3fb0de0
1 parent 4414b5f
commit 3fb0de0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -407,7 +407,7 @@ GEM
     jmespath (1.6.2)
     js_cookie_rails (2.2.0)
       railties (>= 3.1)
-    json (2.9.0)
+    json (2.9.1)
     json-schema (5.1.1)
       addressable (~> 2.8)
       bigdecimal (~> 3.1)
@@ -604,7 +604,7 @@ GEM
       redis-client (>= 0.22.0)
     redis-client (0.23.0)
       connection_pool
-    regexp_parser (2.9.3)
+    regexp_parser (2.10.0)
     reline (0.6.0)
       io-console (~> 0.5)
     representable (3.2.0)
@@ -650,7 +650,7 @@ GEM
     rspec-retry (0.6.2)
       rspec-core (> 3.3)
     rspec-support (3.13.1)
-    rubocop (1.69.2)
+    rubocop (1.70.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)

diff --git a/app/helpers/persons_helper.rb b/app/helpers/persons_helper.rb
@@ -21,7 +21,7 @@ def odd_rank?(rank)
   end
 
   def return_podium_class(result)
-    if (result.roundTypeId == 'f' || result.roundTypeId == 'c') && !result.best_solve.dnf?
+    if (['f', 'c'].include?(result.roundTypeId)) && !result.best_solve.dnf?
       case result.pos
       when 1
         "gold-place"

diff --git a/app/models/event.rb b/app/models/event.rb
@@ -55,7 +55,7 @@ def fewest_moves?
   end
 
   def multiple_blindfolded?
-    self.id == "333mbf" || self.id == "333mbo"
+    ["333mbf", "333mbo"].include?(self.id)
   end
 
   def can_change_time_limit?

diff --git a/lib/qualification.rb b/lib/qualification.rb
@@ -10,7 +10,7 @@ class Qualification
   validates :level, numericality: { only_integer: true, greater_than: 0 }, if: :result_or_ranking?
 
   def result_or_ranking?
-    self.wcif_type == 'attemptResult' || self.wcif_type == 'ranking'
+    ['attemptResult', 'ranking'].include?(self.wcif_type)
   end
 
   def ==(other)