Update string arg names

and "starts" -> "will start" for consistency
thewca · Jan 21, 2025 · 1dd30cb · 1dd30cb
1 parent 5144f92
commit 1dd30cb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/webpacker/components/CompetitionsOverview/ListViewSection.js b/app/webpacker/components/CompetitionsOverview/ListViewSection.js
@@ -454,7 +454,7 @@ function RegistrationStatus({ comp, isLoading }) {
         content={
           I18n.t(
             'competitions.index.tooltips.registration.opens_in',
-            { duration: DateTime.fromISO(comp.registration_open).toRelative(toRelativeOptions.default) },
+            { relativeDate: DateTime.fromISO(comp.registration_open).toRelative(toRelativeOptions.default) },
           )
         }
         position="top center"
@@ -470,7 +470,7 @@ function RegistrationStatus({ comp, isLoading }) {
         content={
           I18n.t(
             'competitions.index.tooltips.registration.closed',
-            { days: DateTime.fromISO(comp.start_date).toRelative(toRelativeOptions.roundUpAndAtBestDayPrecision) },
+            { relativeDate: DateTime.fromISO(comp.start_date).toRelative(toRelativeOptions.roundUpAndAtBestDayPrecision) },
           )
         }
         position="top center"

diff --git a/app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx b/app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx
@@ -25,10 +25,10 @@ const competingStatusIcon = (competingStatus) => {
 
 const registrationStatusIconText = (competition) => {
   if (competition.registration_status === 'not_yet_opened') {
-    return I18n.t('competitions.index.tooltips.registration.opens_in', { duration: DateTime.fromISO(competition.registration_open).toRelative(toRelativeOptions.default) });
+    return I18n.t('competitions.index.tooltips.registration.opens_in', { relativeDate: DateTime.fromISO(competition.registration_open).toRelative(toRelativeOptions.default) });
   }
   if (competition.registration_status === 'past') {
-    return I18n.t('competitions.index.tooltips.registration.closed', { days: DateTime.fromISO(competition.start_date).toRelative(toRelativeOptions.roundUpAndAtBestDayPrecision) });
+    return I18n.t('competitions.index.tooltips.registration.closed', { relativeDate: DateTime.fromISO(competition.start_date).toRelative(toRelativeOptions.roundUpAndAtBestDayPrecision) });
   }
   if (competition.registration_status === 'full') {
     return I18n.t('competitions.index.tooltips.registration.full');

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1575,8 +1575,8 @@ en:
         recent: "Last %{count} days"
         #context: the registration status icon
         registration:
-          opens_in: "Registration will open %{duration}."
-          closed: "Registration has closed. Competition starts %{days}."
+          opens_in: "Registration will open %{relativeDate}."
+          closed: "Registration has closed. Competition will start %{relativeDate}."
           open: "Registration is open!"
           full: "Competitor limit reached, new registrations will go to the waiting list."
       no_more_comps: "No more competitions."