Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More porting from requests to urllib3 #2773

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jku
Copy link
Member

@jku jku commented Jan 29, 2025

This is related to #2762 (that aims to replace RequestsFetcher with Urllib3Fetcher) and takes care of the remaining requests use cases in the code base.

This does not really make sense without 2762 so I'm leaving this as draft for now.

This is related to theupdateframework#2762 (that aims to replace RequestsFetcher with
Urllib3Fetcher) and takes care of the remaining requests use cases in
the code base.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku changed the title More porting from from requests to urllib3 More porting from requests to urllib3 Jan 29, 2025
@jku
Copy link
Member Author

jku commented Jan 30, 2025

Some additional changes that could be included here:

  • replace requests with urllib3 in our dependencies -- this drops 3 more indirect dependencies
  • Add documentation to RequestsFetcher
    • class is deprecated and will be removed in future
    • users of RequestsFetcher now need to depend on requests themselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant