testbench: dont build testbench, tools and topologies in the source directory #9871
+75
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow both scripts to be executed from the SOF FW directory or the parent SOF workspace directory without an environment variable. This simplifies usage and opens the way for vscode integration. Signed-off-by: Liam Girdwood <[email protected]>
Dont built binaries in the source directory, build in the workspace. Signed-off-by: Liam Girdwood <[email protected]>
Fix the indentation. Signed-off-by: Liam Girdwood <[email protected]>
Move all testbench build and test collateral outside of the SOF source directory to the workspace directory. Signed-off-by: Liam Girdwood <[email protected]>
Move the test data files outside of the source directory and add more context to their names for easier lookup. Do the same with the outfile and generate it if we keep the temporary files. Signed-off-by: Liam Girdwood <[email protected]>
lgirdwood
requested review from
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
I expect this to break CI if we have hard coded assumptions of where to find certain binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all topologies, testbench and some tools are built within the FW source directory unlike FW which has separate binary destination directories outside of the main FW source directory.
This series moves all tools, testbench and topologies binaries to outside the source directory to the parent SOF "workspace" directory alongside the FW build output directories.