Tools: Tune: SRC: Update generator to produce similar as edited #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lyakh
reviewed
Feb 9, 2024
tools/tune/src/src_export_table_2s.m
Outdated
| fprintf(fh, '#include <stdint.h>\n'); | ||
| fprintf(fh,'\n'); | ||
|
|
||
| fprintf(fh, '/* SRC table */\n'); | ||
| switch ctype | ||
| case 'float' | ||
| fprintf(fh, '%s fir_one = 1.0;\n', vtype); | ||
| fprintf(fh, 'const %s fir_one = 1.0;\n', vtype); | ||
| fprintf(fh, 'struct src_stage src_double_1_1_0_0 = { 0, 0, 1, 1, 1, 1, 1, 0, 1.0, &fir_one };\n'); | ||
| fprintf(fh, 'struct src_stage src_double_0_0_0_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0.0, &fir_one };\n'); |
There was a problem hiding this comment.
what about these? Aren't they const now too?
There was a problem hiding this comment.
Yep, you are right!
singalsu
force-pushed
the
src_tune_recent_changes_to_generator
branch
from
d169c50 to
baef046
Compare
This patch makes to SRC coefficients tables generator same changes as done in recent git commits. commit 88fdb10 ("audio: src: rename sample rate converter coefficient folder name") moved coefficients files location to src/audio/src/coefs. commit 90fef5a ("src_lite: add module") removed include of src.h from upper level due to another src-lite version. 'commit 7f4e6ae ("src: make coefficients constant") added const to struct src_stage. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
src_tune_recent_changes_to_generator
branch
from
baef046 to
e035c9d
Compare
lyakh
approved these changes
Feb 23, 2024
| fprintf(fh, '\t%d, %d, %d, %d, %d, %d, %d, %d, %f,\n\t%s};\n', ... | ||
| src.idm, src.odm, src.num_of_subfilters, ... | ||
| src.subfilter_length, src.filter_length, ... | ||
| src.blk_in, src.blk_out, src.halfband, ... | ||
| src.gain, vfn); | ||
| case { 'int16' 'int24' 'int32' } | ||
| fprintf(fh, 'struct src_stage %s = {\n', sfn); | ||
| fprintf(fh, 'const struct src_stage %s = {\n', sfn); |
There was a problem hiding this comment.
A side comment, instead of datestr(now(), 'yyyy'); I suggest currentYear = datestr(datetime('now'), 'yyyy');
And there's a unused code , please consider removing it
%% Plot to compare
if 0
f = linspace(0, fs/2, 1000);
h1 = freqz(src.coefs/src.L, 1, f, fs);
h2 = freqz(bq0/sref/src.L, 1, f, fs);
h3 = freqz(bi/sref/src.L, 1, f, fs);
figure;
plot(f, 20*log10(abs(h1)), f, 20*log10(abs(h2)), f, 20*log10(abs(h3)));
grid on;
fprintf('Original = %4.1f dB, optimized = %4.1f dB, delta = %4.1f dB\n', ...
sb1, sb2, sb1-sb2);
end
| @@ -82,45 +82,44 @@ | |||
| um_tmp = unique_modes(i,:); | |||
| if isequal(um_tmp(1:2),[1 1]) || isequal(um_tmp(1:2),[0 0]) | |||
| else | |||
| fprintf(fh, '#include <%ssrc_%s_%d_%d_%d_%d.h>\n', ... | |||
| ppath, prof_ctype, um_tmp(1:4)); | |||
| fprintf(fh, '#include \"src_%s_%d_%d_%d_%d.h\"\n', ... | |||
There was a problem hiding this comment.
unused variables are there ppath in the function call, please consider ~
ShriramShastry
approved these changes
Feb 23, 2024
lgirdwood
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
@singalsu can you make incremental fixes for @ShriramShastry comments. Thanks !
Sure, @ShriramShastry thanks! I'll fix them later. That "if 0" code might be useful, maybe under some debug option. The ppath is clear to remove after the directory locations change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes to SRC coefficients tables generator same changes as done in recent git commits.
commit 88fdb10 ("audio: src: rename sample rate converter coefficient folder name") moved coefficients files location to src/audio/src/coefs.
commit 90fef5a ("src_lite: add module") removed include of src.h from upper level due to another src-lite version.
'commit 7f4e6ae ("src: make coefficients constant") added const to struct src_stage.