Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-case: add set -e to 7 function test #400

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

RuiqingX
Copy link
Contributor

Fixes: #312

Signed-off-by: RuiqingX [email protected]

@RuiqingX RuiqingX requested a review from a team as a code owner September 23, 2020 07:35
@RuiqingX
Copy link
Contributor Author

I have done some tests on sh-jsl-rvp-hda-01 and sh-tgl-shuri-hda-02.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 23, 2020

For a change like this I think we really need to wait for a green CI + make sure the next daily test run after merge is all green too.

@aiChaoSONG
Copy link

I have checked the test result, The timeout on CML_RVP_SDW with alsabat test case is actually a failure, root cause is that the test framework doesn't know the exit code 21, so it fallback to timeout, but I don't think it is related to the PR. @RuiqingX Maybe you go to jf-cml-rvp-sdw-3 or other CML_RVP_SDW and run a manual test with the alsabat case?

@RuiqingX
Copy link
Contributor Author

I've checked with Xiuli just now, and I have validated this issue on sh-cml-rvp-sdw-04, test result is pass.

@keqiaozhang
Copy link
Contributor

I have checked the test result, The timeout on CML_RVP_SDW with alsabat test case is actually a failure, root cause is that the test framework doesn't know the exit code 21, so it fallback to timeout, but I don't think it is related to the PR. @RuiqingX Maybe you go to jf-cml-rvp-sdw-3 or other CML_RVP_SDW and run a manual test with the alsabat case?

alsabat failed on CML-RVP-SDW is caused by the codec prefix_name change in machine description, so the amixer control names
have also changed accordingly. I have submitted a PR105 to fix it.

Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @keqiaozhang for correcting me on the alsabat fi, good to know that.

@xiulipan xiulipan merged commit 2e24024 into thesofproject:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sof-test] add set -e to all test cases (Unless You Love Debugging)
5 participants