Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod: sof_remove.sh: add snd_sof_ipc_test, snd_sof_probes support #187

Merged
merged 1 commit into from
Apr 17, 2020
Merged

kmod: sof_remove.sh: add snd_sof_ipc_test, snd_sof_probes support #187

merged 1 commit into from
Apr 17, 2020

Conversation

fredoh9
Copy link
Collaborator

@fredoh9 fredoh9 commented Apr 13, 2020 •
edited
Loading

When multiclient changes are merged, snd_sof_ipc_test is first client
module to test ipc flood test. 2nd client is snf_sof_probes whilch support
Probe feature. The client modules need to be removed before snd_sof.

Signed-off-by: Fred Oh [email protected]

@fredoh9 fredoh9 requested review from Bin-QA and marc-hb as code owners April 13, 2020 18:53
@fredoh9
Copy link
Collaborator Author

fredoh9 commented Apr 13, 2020

This patch depends on thesofproject/linux#1841 and thesofproject/kconfig#31.

@fredoh9 fredoh9 force-pushed the fix/ipc_flood_test_client branch from e16c595 to 3340162 Compare April 13, 2020 19:46
@Bin-QA
Copy link
Contributor

Bin-QA commented Apr 14, 2020

@fredoh9 how about add the file system detect for setup default debugfs
I'm afraid some kernel is /sys/kernel/debug/sof/ipc_flood_count, some kernel is /sys/kernel/debug/sof/ipc-flood-test/ipc_flood_count

@fredoh9 fredoh9 force-pushed the fix/ipc_flood_test_client branch from 3340162 to 3a96a48 Compare April 15, 2020 19:24
@fredoh9 fredoh9 mentioned this pull request Apr 15, 2020
Closed
@fredoh9 fredoh9 changed the title sof-test: change debugfs root for ipc flood test kmod: sof_remove.sh: add snd_sof_ipc_test, snd_sof_probes support Apr 15, 2020
@fredoh9 fredoh9 force-pushed the fix/ipc_flood_test_client branch from 3a96a48 to e37957e Compare April 15, 2020 19:38
@fredoh9
Copy link
Collaborator Author

fredoh9 commented Apr 15, 2020 •
edited
Loading

@fredoh9 how about add the file system detect for setup default debugfs
I'm afraid some kernel is /sys/kernel/debug/sof/ipc_flood_count, some kernel is /sys/kernel/debug/sof/ipc-flood-test/ipc_flood_count

This is good to have. We don't change the root of debugfs often. But to minimize test failures in between the transition, this is good idea.
I removed location change and only pushed kmod change. sof_remove.sh change is safe to merge.
For location change and also for enhancement after PR1841, I created new issue, #191.

@fredoh9 fredoh9 force-pushed the fix/ipc_flood_test_client branch from e37957e to b3fe9b0 Compare April 15, 2020 22:17
Bin-QA
Bin-QA previously approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@Bin-QA Bin-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @aiChaoSONG please take review for this

aiChaoSONG
aiChaoSONG previously approved these changes Apr 16, 2020
View reviewed changes
Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please rebase, and then let's get this merged.

@fredoh9
kmod: sof_remove.sh: add snd_sof_ipc_test, snd_sof_probes support
b4c6764 
When multiclient changes are merged, snd_sof_ipc_test is first client
module to test ipc flood test. 2nd client is snf_sof_probes whilch support
Probe feature. The client modules need to be removed before snd_sof.

Signed-off-by: Fred Oh <[email protected]>
@fredoh9 fredoh9 dismissed stale reviews from aiChaoSONG and Bin-QA via b4c6764 April 16, 2020 19:06
@fredoh9 fredoh9 force-pushed the fix/ipc_flood_test_client branch from b3fe9b0 to b4c6764 Compare April 16, 2020 19:06
@marc-hb marc-hb removed their request for review April 16, 2020 19:27
@aiChaoSONG aiChaoSONG merged commit e81a06f into thesofproject:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranj063 ranj063 ranj063 approved these changes

@aiChaoSONG aiChaoSONG aiChaoSONG left review comments

@Bin-QA Bin-QA Bin-QA left review comments

@plbossart plbossart Awaiting requested review from plbossart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredoh9 @Bin-QA @ranj063 @aiChaoSONG