Simultaneous playback capture shellcheck fixes #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous source reference for lib.sh triggers shellcheck errors. This clears them up. Signed off by Greg Galloway <[email protected]>
Rewrote exit code checks. Rewrote antiquated and deprecated syntax and commands. (Removed expr and braces) Signed-off-by: Greg Galloway <[email protected]>
marc-hb
approved these changes
Jun 6, 2023
I do like this phrasing much more. If I adjust the source reference in future files, I'll call this out properly. |
I thought this was referring to the addition of the meta Now I realize this is probably just a confusing way to say "add missing quotes"? |
marc-hb
reviewed
Jun 9, 2023
| @@ -74,38 +75,38 @@ do | |||
| setup_kernel_check_point | |||
| dlogi "===== Testing: (Loop: $i/$loop_cnt) =====" | |||
| # following sof-tplgreader, split 'both' pipelines into separate playback & capture pipelines, with playback occurring first | |||
| for order in $(seq 0 2 $(expr $PIPELINE_COUNT - 1)) | |||
| for order in $(seq 0 2 $(( "$PIPELINE_COUNT" - 1))) | |||
There was a problem hiding this comment.
Suggested change
| for order in $(seq 0 2 $(( "$PIPELINE_COUNT" - 1))) | |
| for order in $(seq 0 2 $(( PIPELINE_COUNT - 1))) |
|
All tests passed, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shellcheck errors per #729
Corrected a source reference. Fixed various quoting issues. Corrected exit codes and updated syntax.
Signed-off-by: Greg Galloway [email protected]