Change thread async duration #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes Let's bump the check between messages to be 12 hours instead of 60 minutes.
Shadowfiend
approved these changes
Nov 18, 2024
| @@ -31,7 +31,7 @@ import { | |||
|
|
|||
| // The maximum time between any two messages after which a thread is considered | |||
| // async. | |||
| const MAX_HEURISTIC_SYNC_THREAD_DURATION = 60 * MINUTE // 60 * MINUTE | |||
| const MAX_HEURISTIC_SYNC_THREAD_DURATION = 12 * HOUR // 60 * MINUTE | |||
There was a problem hiding this comment.
Let's hold off on this change; it's predicated on the assumption that a quick thread is acceptable, but 12 hours really isn't a quick thread anymore.
Let's see what happens if we just fix the other issue first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Let's bump the check between messages to be 12 hours instead of 60 minutes.