Refactor embeds with better logging

This changes the `fixTwitterEmbeds` to run a main `processTwitterMessage` where we output the specific user, channel, timestamp and message id to `logger.info` while outputting the entire message to `logger.debug`

discord-scripts/fix-twitter-embed.ts

@@ -67,41 +67,58 @@ async function workingTwitterEmbeds(
 //
 // See https://github.com/FixTweet/FxTwitter for more.
 export default function fixTwitterEmbeds(discordClient: Client, robot: Robot) {
+  const formatMessageDetails = (message: Message) => {
+    const user = message.author?.tag || "Unknown User"
+    const channel = message.channel || "Unknown Channel"
+    const timestamp = message.createdAt.toISOString()
+    const messageId = message.id
+    return `User: ${user}, Channel: ${channel}, Timestamp: ${timestamp}, Message ID: ${messageId}`
+  }
+
   // Process only messages that match the Twitter URL pattern
+  const processTwitterMessage = async (
+    message: Message,
+    logger: typeof robot.logger,
+    oldMessage?: Message,
+  ) => {
+    const messageDetails = formatMessageDetails(message)
+
+    logger.info(
+      `fixTwitterEmbeds: processing message details ${messageDetails}`,
+    )
+
+    try {
+      await workingTwitterEmbeds(message, logger, oldMessage)
+    } catch (err) {
+      logger.error(
+        `fixTwitterEmbeds: failed to process message ${messageDetails}: ${err}`,
+      )
+    }
+  }
+
   discordClient.on("messageCreate", (message) => {
     robot.logger.debug(
       `fixTwitterEmbeds: processing new message ${message.content}`,
     )
+
     if (message.content?.match(twitterUrlRegExp)) {
-      robot.logger.info(
-        `fixTwitterEmbeds: processing new message ${message.content}`,
-      )
-      workingTwitterEmbeds(message, robot.logger).catch((err) => {
-        robot.logger.error(
-          `fixTwitterEmbeds: failed to process new message ${message.content}: ${err}`,
-        )
-      })
+      processTwitterMessage(message, robot.logger)
     }
   })
 
   discordClient.on("messageUpdate", (oldMessage, newMessage) => {
     robot.logger.debug(
       `fixTwitterEmbeds: processing updated message ${newMessage.content}`,
     )
+
     if (
       newMessage.content?.match(twitterUrlRegExp) ||
       oldMessage?.content?.match(twitterUrlRegExp)
     ) {
-      robot.logger.info(
-        `fixTwitterEmbeds: processing updated message ${newMessage.content}`,
-      )
-
-      workingTwitterEmbeds(newMessage, robot.logger, oldMessage).catch(
-        (err) => {
-          robot.logger.error(
-            `fixTwitterEmbeds: failed to process updated message ${newMessage.content}: ${err}`,
-          )
-        },
+      processTwitterMessage(
+        newMessage as Message,
+        robot.logger,
+        oldMessage as Message,
       )
     }
   })