Add strikethrough support #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new optional converter `StrikethroughConverter`, mention it in the readme and add tests for it
BentiGorlich
commented
Dec 9, 2024
| > [!CAUTION] | ||
| > [!CAUTION] |
There was a problem hiding this comment.
Sorry about this change, but PHPStork wouldn't let me revert this 😅
melroy89
approved these changes
Dec 10, 2024
|
@BentiGorlich Thank you, but @melroy89 Do you have any thoughts on when this will be merged? |
|
Well it might be deprecated, but that doesn't mean that it isn't used anymore. The issue we received about the parsing problem contained the |
although I approved it. I don't have merge rights on this repo. Better ask @colinodell |
|
please merge this @colinodell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
StrikethroughConverterwhich converts<strike>Some Text</strike>->~~Some Text~~<del>Some Text</del>->~~Some Text~~